[PATCH] D54894: [clangd] Enable auto-index behind a flag.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Sorry for the bugs, thanks for the fixes :D



================
Comment at: clangd/ClangdServer.cpp:515
+    if (BackgroundIdx)
+      BackgroundIdx->blockUntilIdleForTest();
+    return true;
----------------
Should we change `BackgroundIndex`s signature to indicate success failure? Not sure it can block but just in case something weird happens.


================
Comment at: test/clangd/background-index.test:13
+# The background index should allow us to go-to-definition on foo().
+# RUN: clangd -background-index -lit-test < %t/definition.jsonrpc | FileCheck %t/definition.jsonrpc
+
----------------
shouldn't this one be running ?


================
Comment at: test/clangd/background-index.test:16
+# Test that the index is writing files in the expected location.
+# RUN: ls %t/.clangd-index/foo.cpp.*.idx
+
----------------
and this


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54894/new/

https://reviews.llvm.org/D54894