[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 06:29:35 PST 2018


erichkeane added inline comments.


================
Comment at: include/clang/Basic/IdentifierTable.h:119
 
+  IdentifierInfo()
+      : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false),
----------------
riccibruno wrote:
> erichkeane wrote:
> > Instead of putting these in an initializer, can you default-init each of them inline, then make this =default?
> Nope, you cannot default-init bit-fields (at least not until c++20)
Ugg, you're right.  I hate bitfields.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54866/new/

https://reviews.llvm.org/D54866





More information about the cfe-commits mailing list