[PATCH] D54851: [clangd] Tune down scope boost for global scope

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 04:14:57 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347548: [clangd] Tune down scope boost for global scope (authored by ioeric, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D54851?vs=175106&id=175226#toc

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54851/new/

https://reviews.llvm.org/D54851

Files:
  clangd/FileDistance.cpp


Index: clangd/FileDistance.cpp
===================================================================
--- clangd/FileDistance.cpp
+++ clangd/FileDistance.cpp
@@ -196,11 +196,11 @@
     // symbols in it, and there is pattern where using-namespace is used in
     // place of enclosing namespaces (e.g. in implementation files).
     if (S == Preferred)
-      Param.Cost = S == "" ? 2 : 0;
+      Param.Cost = S == "" ? 4 : 0;
     else if (Preferred.startswith(S) && !S.empty())
       continue; // just rely on up-traversals.
     else
-      Param.Cost = S == "" ? 5 : 2;
+      Param.Cost = S == "" ? 6 : 2;
     auto Path = scopeToPath(S);
     // The global namespace is not 'near' its children.
     Param.MaxUpTraversals = std::max(Path.second - 1, 0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54851.175226.patch
Type: text/x-patch
Size: 757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181126/64e8df99/attachment.bin>


More information about the cfe-commits mailing list