[PATCH] D54796: [clangd] C++ API for emitting file status

[Jan Korous via Phabricator via cfe-commits]

jkorous added a comment.

Hi @hokein, I am just keeping up to date with changes.



================
Comment at: clangd/ClangdServer.h:39
 
+// FIXME: find a better name.
 class DiagnosticsConsumer {
----------------
It would be unfortunate to have this name clashing with `clang::DiagnosticsConsumer` indeed.
How about something like `FileEventConsumer`?


================
Comment at: clangd/TUScheduler.cpp:367
       IdleASTs.take(this);
+      FStatus.messages.push_back("fail to build CompilerInvocation;");
+      Callbacks.onFileUpdated(FStatus);
----------------
Wouldn't some different failure status like `FileStatusKind::FailedBuild` be appropriate here?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54796/new/

https://reviews.llvm.org/D54796