[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 23 07:24:04 PST 2018


Anastasia added a comment.

In https://reviews.llvm.org/D54253#1306124, @asavonic wrote:

> FWIW, I'd vote for the first revision of this patch. From my
>  understanding, the test verifies that libclang is able to parse OpenCL
>  code correctly. It doesn't do anything specific to x86: target for x86 just
>  happens to support a set of OpenCL extensions.


I am trying to understand what exactly does it bring into testing if the code doesn't have anything target specific in there?

Tests are not entirely free, so we can't test absolutely everything.


https://reviews.llvm.org/D54253





More information about the cfe-commits mailing list