[PATCH] D52273: [clangd] Initial implementation of expected types

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 22 07:41:17 PST 2018


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/ExpectedTypes.cpp:8
+
+namespace clang {
+namespace clangd {
----------------
nit: using namespace llvm (until/unless we switch other files)


================
Comment at: unittests/clangd/ExpectedTypeTest.cpp:33
+protected:
+  void build(llvm::StringRef Code) {
+    assert(!AST && "AST built twice");
----------------
drop llvm:: here and below?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52273





More information about the cfe-commits mailing list