[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a minor commenting request.



================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4121
 
+/// \brief Matches expressions with potential side effects.
+///
----------------
side effects. -> side effects other than producing a value, such as a calling a function, throwing an exception, or reading a volatile variable.


Repository:
  rC Clang

https://reviews.llvm.org/D54830