[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 20 18:34:03 PST 2018


Eugene.Zelenko added inline comments.


================
Comment at: docs/clang-tidy/checks/abseil-duration-comparison.rst:11
+compared against a floating-pointer value, truncation during the ``Duration``
+conversion might yield a different result.  In practice this is very rare, and
+still indicates a bug which should be fixed.
----------------
Please fix double space.


================
Comment at: docs/clang-tidy/checks/abseil-duration-comparison.rst:34
+  if (absl::Microseconds(x) < d) ...
+..
----------------
Please remove ..


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54737





More information about the cfe-commits mailing list