[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 20 12:28:27 PST 2018
ABataev added a comment.
In https://reviews.llvm.org/D54764#1304606, @jdenny wrote:
> In https://reviews.llvm.org/D54764#1304573, @ABataev wrote:
>
> > I'm fine with the patch,
>
>
> Thanks for the quick reviews. I'll push soon.
>
> > the original intention was to handle a possible situation where we may have several debug locations with the same line numbers.
>
> We were afraid of that. If we find we really need this use case, we'll have to find a nicer way to express it. For reference, this use case is discussed under S1 here:
>
> http://lists.llvm.org/pipermail/llvm-dev/2018-May/123258.html
Ok, got it. Thanks for the patch!
Repository:
rC Clang
https://reviews.llvm.org/D54764
More information about the cfe-commits
mailing list