[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.
Umann Kristóf via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 20 10:16:52 PST 2018
Szelethus added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386
+ }
+ // Provide the caller with the classification of the object
+ // we've obtained here accidentally, for later use.
+ return OK;
----------------
NoQ wrote:
> Szelethus wrote:
> > Maybe move this in-class?
> Mmm, what do you mean?
`explain.*` sounds like it either returns a string, or writes a stream object, but the return type isn't `void` nor string, maybe it'd be worth to put this comment in-class.
But yea, this is over the top nitpicking, I don't insist :)
https://reviews.llvm.org/D54560
More information about the cfe-commits
mailing list