[PATCH] D52274: [clangd] Collect and store expected types in the index

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol &S, UniqueStringSaver &Strings,
+                BumpPtrAllocator &Arena) {
   visitStrings(S, [&](StringRef &V) { V = Strings.save(V); });
----------------
why these changes?


================
Comment at: clangd/index/SymbolCollector.h:80
+    /// Collect type information. Used to improve code completion ranking.
+    bool CollectTypes = true;
   };
----------------
Why make this an option? Is it expensive in time/size?


================
Comment at: clangd/index/YAMLSerialization.cpp:182
     IO.mapOptional("IncludeHeaders", Sym.IncludeHeaders);
+    IO.mapOptional("Type", Sym.Type);
   }
----------------
also need to update the binary serialization?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52274