[PATCH] D54724: [Driver] Automatically include C++ library dependencies

Dimitry Andric via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 19 22:54:11 PST 2018


dim added a comment.

I think this is the wrong direction, placing "common" code in `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches for different OSes?  Let different OSes handle this in their own way, maybe.

Until now I have not encountered an issue where I needed to add -lpthread to the link command line for a static C++ application; I think that is only needed when you actually use threading primitives?  But still, I would rather see this in the OS-dependent handling functions.


Repository:
  rC Clang

https://reviews.llvm.org/D54724





More information about the cfe-commits mailing list