r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'
Tom Stellard via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 19 16:01:24 PST 2018
On 11/17/2018 08:28 PM, Richard Smith wrote:
> Procedurally, we shouldn't be making other changes at the same time as a backport, but I'd sure like to see "stdlibc++" replaced with the correct "libstdc++" (on trunk and branch).
>
When this gets fixes in trunk, let me know I can merge it to the branch.
-Tom
> On Sat, 17 Nov 2018, 19:00 Arthur O'Dwyer via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org> wrote:
>
> Peanut gallery says: I think the one remaining instance of `-std=libc++` in the tests should be fixed at the same time.
>
> –Arthur
>
> On Sat, Nov 17, 2018 at 9:52 PM Richard Smith via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
>
> Good idea, this LG for a patch release.
>
> On Sat, 17 Nov 2018, 18:48 Shoaib Meenai via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org> wrote:
>
> Could we merge this into 7.0.1? It's a trivial typo fix, and the error message could otherwise be confusing to users (someone brought this up in IRC a few hours ago).____
>
> __ __
>
> *From: *cfe-commits <cfe-commits-bounces at lists.llvm.org <mailto:cfe-commits-bounces at lists.llvm.org>> on behalf of Alex Lorenz via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>>
> *Reply-To: *Alex Lorenz <arphaman at gmail.com <mailto:arphaman at gmail.com>>
> *Date: *Friday, September 7, 2018 at 12:01 PM
> *To: *"cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>" <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>>
> *Subject: *r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'____
>
> __ __
>
> Author: arphaman____
>
> Date: Fri Sep 7 11:59:45 2018____
>
> New Revision: 341697____
>
> __ __
>
> URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D341697-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=MYePhuYEkBYd5aK7fqamBrBRJJGtvC-BPPojLInHah8&e=____
>
> Log:____
>
> warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'____
>
> __ __
>
> Addresses first post-commit feedback for r335081 from Nico____
>
> __ __
>
> Modified:____
>
> cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td____
>
> cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp____
>
> __ __
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td____
>
> URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_include_clang_Basic_DiagnosticFrontendKinds.td-3Frev-3D341697-26r1-3D341696-26r2-3D341697-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=ZQcIenU2yQH3SmDrAhdXm2VKI10aP3_5IoBH-72HxYA&e=____
>
> ==============================================================================____
>
> --- cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td (original)____
>
> +++ cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td Fri Sep 7 11:59:45 2018____
>
> @@ -238,7 +238,7 @@ def warn_option_invalid_ocl_version : Wa____
>
> "OpenCL version %0 does not support the option '%1'">, InGroup<Deprecated>;____
>
> def warn_stdlibcxx_not_found : Warning<____
>
> - "include path for stdlibc++ headers not found; pass '-std=libc++' on the "____
>
> + "include path for stdlibc++ headers not found; pass '-stdlib=libc++' on the "____
>
> "command line to use the libc++ standard library instead">,____
>
> InGroup<DiagGroup<"stdlibcxx-not-found">>;____
>
> }____
>
> __ __
>
> Modified: cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp____
>
> URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Frontend_warning-2Dstdlibcxx-2Ddarwin.cpp-3Frev-3D341697-26r1-3D341696-26r2-3D341697-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=YR_ENMKZ9M1ESvYMVXN6PlRtSZ8bXMsfvYf8QaBm5X4&e=____
>
> ==============================================================================____
>
> --- cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp (original)____
>
> +++ cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp Fri Sep 7 11:59:45 2018____
>
> @@ -1,5 +1,5 @@____
>
> // RUN: %clang -cc1 -triple arm64-apple-ios6.0.0 -isysroot %S/doesnotexist %s 2>&1 | FileCheck %s____
>
> // RUN: %clang -cc1 -triple arm64-apple-ios6.0.0 -isysroot %S/doesnotexist -stdlib=libc++ %s -verify____
>
> -// CHECK: include path for stdlibc++ headers not found; pass '-std=libc++' on the command line to use the libc++ standard library instead____
>
> +// CHECK: include path for stdlibc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead____
>
> // expected-no-diagnostics____
>
> __ __
>
> __ __
>
> ___________________________________________________
>
> cfe-commits mailing list____
>
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>____
>
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=Q8IVygsR4GuCJTOTCl7xRLj0JSxkuoS-q2HhesuNe4U&e=____
>
> __ __
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
More information about the cfe-commits
mailing list