[PATCH] D54676: [AST] Pack CallExpr

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 19 11:03:53 PST 2018


riccibruno planned changes to this revision.
riccibruno added a comment.

In https://reviews.llvm.org/D54676#1303176, @rjmccall wrote:

> You can have more arguments than parameters because of varargs.  Even putting that aside, no, I think we generally shouldn't go backwards on these limits.  Anyway, packing right up to the limits imposed by `NumExprBits` probably isn't a great idea.


Alright, I think it make sense to wait until it is possible to store the arguments in a trailing array.
There are a few places where `Sema` resize the array of arguments in `CallExpr`.
>From a quick look it seems it should be possible to get rid of them. For now let's mark
this "changes planned".


Repository:
  rC Clang

https://reviews.llvm.org/D54676





More information about the cfe-commits mailing list