r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

[Richard Smith via cfe-commits]

Procedurally, we shouldn't be making other changes at the same time as a
backport, but I'd sure like to see "stdlibc++" replaced with the correct
"libstdc++" (on trunk and branch).

On Sat, 17 Nov 2018, 19:00 Arthur O'Dwyer via cfe-commits <
cfe-commits at lists.llvm.org wrote:

> Peanut gallery says: I think the one remaining instance of `-std=libc++`
> in the tests should be fixed at the same time.
>
> –Arthur
>
> On Sat, Nov 17, 2018 at 9:52 PM Richard Smith via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Good idea, this LG for a patch release.
>>
>> On Sat, 17 Nov 2018, 18:48 Shoaib Meenai via cfe-commits <
>> cfe-commits at lists.llvm.org wrote:
>>
>>> Could we merge this into 7.0.1? It's a trivial typo fix, and the error
>>> message could otherwise be confusing to users (someone brought this up in
>>> IRC a few hours ago).
>>>
>>>
>>>
>>> *From: *cfe-commits <cfe-commits-bounces at lists.llvm.org> on behalf of
>>> Alex Lorenz via cfe-commits <cfe-commits at lists.llvm.org>
>>> *Reply-To: *Alex Lorenz <arphaman at gmail.com>
>>> *Date: *Friday, September 7, 2018 at 12:01 PM
>>> *To: *"cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
>>> *Subject: *r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++'
>>> instead of '-std'
>>>
>>>
>>>
>>> Author: arphaman
>>>
>>> Date: Fri Sep  7 11:59:45 2018
>>>
>>> New Revision: 341697
>>>
>>>
>>>
>>> URL:
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D341697-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=MYePhuYEkBYd5aK7fqamBrBRJJGtvC-BPPojLInHah8&e=
>>>
>>> Log:
>>>
>>> warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'
>>>
>>>
>>>
>>> Addresses first post-commit feedback for r335081 from Nico
>>>
>>>
>>>
>>> Modified:
>>>
>>>     cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td
>>>
>>>     cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp
>>>
>>>
>>>
>>> Modified: cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td
>>>
>>> URL:
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_include_clang_Basic_DiagnosticFrontendKinds.td-3Frev-3D341697-26r1-3D341696-26r2-3D341697-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=ZQcIenU2yQH3SmDrAhdXm2VKI10aP3_5IoBH-72HxYA&e=
>>>
>>>
>>> ==============================================================================
>>>
>>> --- cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td (original)
>>>
>>> +++ cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td Fri Sep  7
>>> 11:59:45 2018
>>>
>>> @@ -238,7 +238,7 @@ def warn_option_invalid_ocl_version : Wa
>>>
>>>    "OpenCL version %0 does not support the option '%1'">,
>>> InGroup<Deprecated>;
>>>
>>> def warn_stdlibcxx_not_found : Warning<
>>>
>>> -  "include path for stdlibc++ headers not found; pass '-std=libc++' on
>>> the "
>>>
>>> +  "include path for stdlibc++ headers not found; pass '-stdlib=libc++'
>>> on the "
>>>
>>>    "command line to use the libc++ standard library instead">,
>>>
>>>    InGroup<DiagGroup<"stdlibcxx-not-found">>;
>>>
>>> }
>>>
>>>
>>>
>>> Modified: cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp
>>>
>>> URL:
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Frontend_warning-2Dstdlibcxx-2Ddarwin.cpp-3Frev-3D341697-26r1-3D341696-26r2-3D341697-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=YR_ENMKZ9M1ESvYMVXN6PlRtSZ8bXMsfvYf8QaBm5X4&e=
>>>
>>>
>>> ==============================================================================
>>>
>>> --- cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp (original)
>>>
>>> +++ cfe/trunk/test/Frontend/warning-stdlibcxx-darwin.cpp Fri Sep  7
>>> 11:59:45 2018
>>>
>>> @@ -1,5 +1,5 @@
>>>
>>> // RUN: %clang -cc1 -triple arm64-apple-ios6.0.0 -isysroot
>>> %S/doesnotexist %s 2>&1 | FileCheck %s
>>>
>>> // RUN: %clang -cc1 -triple arm64-apple-ios6.0.0 -isysroot
>>> %S/doesnotexist -stdlib=libc++ %s -verify
>>>
>>> -// CHECK: include path for stdlibc++ headers not found; pass
>>> '-std=libc++' on the command line to use the libc++ standard library instead
>>>
>>> +// CHECK: include path for stdlibc++ headers not found; pass
>>> '-stdlib=libc++' on the command line to use the libc++ standard library
>>> instead
>>>
>>> // expected-no-diagnostics
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> cfe-commits mailing list
>>>
>>> cfe-commits at lists.llvm.org
>>>
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=IqJdIRn5MxFdIr2LEpZYhRLQTay50tZijNg6klhhdRA&s=Q8IVygsR4GuCJTOTCl7xRLj0JSxkuoS-q2HhesuNe4U&e=
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181117/603bcf99/attachment-0001.html>