[PATCH] D54654: Correct CreateAlignmentAssumption to check sign and power-of-2 (Clang Part)

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 16 20:02:50 PST 2018


hfinkel added a comment.

> As discussed on IRC, check sign/power of 2 correctly for the alignment assumptions.

"As discussed on IRC" is not appropriate for a commit message. The rationale must be documented here.

> I hope that extra is-power-of-two won't confuse the optimizer.

Probably would unless it gets constant folded.


Repository:
  rC Clang

https://reviews.llvm.org/D54654





More information about the cfe-commits mailing list