[PATCH] D54379: Add Hurd toolchain support to Clang

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/Driver/ToolChains/Hurd.cpp:84
+  const Driver &D = getDriver();
+  std::string SysRoot = computeSysRoot();
+
----------------
kristina wrote:
> Move semantics? Or is this guaranteed elision (I'm not sure)?
If you're talking about the initialization of `SysRoot`, yes, initializing a local variable from a temporary is a guaranteed copy-elision, and adding `std::move` will actually inhibit the optimization.


Repository:
  rC Clang

https://reviews.llvm.org/D54379