[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I'm not certain if it will be possible to devise test cases for the two diagnostics I pointed out or not, but otherwise, this LGTM as far as the implementation goes. I don't know enough about AVR to sign off on whether the patch logic is correct or not.



================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:35
+  InGroup<AVRRtlibLinkingQuirks>;
+def warn_drv_avr_gcc_not_found: Warning<
+  "no avr-gcc installation can be found on the system, "
----------------
I don't see a test case for this diagnostic.


================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:40
+def warn_drv_avr_libc_not_found: Warning<
+  "no avr-libc installation can be found on the system, "
+  "cannot link standard libraries">,
----------------
Or this one.


Repository:
  rC Clang

https://reviews.llvm.org/D54334