[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

[Dylan McKay via Phabricator via cfe-commits]

dylanmckay updated this revision to Diff 174359.
dylanmckay marked 6 inline comments as done.
dylanmckay added a comment.

- Remove link to BugZilla in diagnostic
- Use StringRef for a static string array rather than std::string
- Elide braces
- Dereference an Optional in-place rather than persisting it for one use
- Use llvm::None rather than explicit Optional() constructor


Repository:
  rC Clang

https://reviews.llvm.org/D54334

Files:
  include/clang/Basic/DiagnosticDriverKinds.td
  include/clang/Basic/DiagnosticGroups.td
  lib/Driver/ToolChains/AVR.cpp
  lib/Driver/ToolChains/AVR.h
  lib/Driver/ToolChains/Gnu.cpp
  test/Driver/avr-link-mcu-family-unimplemented.c
  test/Driver/avr-link-no-mcu-specified.c
  test/Driver/avr-link-nostdlib-nodefaultlibs.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54334.174359.patch
Type: text/x-patch
Size: 13172 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181116/b03f1859/attachment.bin>