[PATCH] D54553: [clangd] Fix crash hovering on non-decltype trailing return

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.

This seems ready, so putting myself in as a reviewer.
Let me know if there's more work to do and I you don't want the review yet.

Thanks for the fix, just a single NIT comment.



================
Comment at: clangd/XRefs.cpp:628
       DeducedType = AT->getDeducedType();
-    } else {
+    } else if (const DecltypeType *DT = dyn_cast<DecltypeType>(D->getReturnType())) {
       // auto in a trailing return type just points to a DecltypeType and
----------------
NIT: use 'auto' here, since the type is spelled explicitly in the initializer.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54553