[PATCH] D54519: [clangd] Fix no results returned for global symbols in dexp

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 15 01:50:02 PST 2018


ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:64
+    // add the global scope to the request.
+    Request.Scopes = {""};
 
----------------
ioeric wrote:
> I think the old behavior used `AnyScope` for a unqualified name. Do we want to keep that?
nvm, this is `getSymbolIDsFromIndex` not `fuzzyfind`. Looks good.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54519





More information about the cfe-commits mailing list