[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

[Balázs Kéri via Phabricator via cfe-commits]

balazske added inline comments.


================
Comment at: include/clang/AST/ASTImporter.h:192
     ///
-    /// \returns the equivalent declaration in the "to" context, or a NULL type
-    /// if an error occurred.
+    /// \returns The equivalent declaration in the "to" context, or the import
+    /// error.
----------------
a_sidorin wrote:
> an import error?
I do not know what is the correct, but a specific import error is returned, that occurred during the import.


================
Comment at: include/clang/AST/ASTImporter.h:198
+    }
+    // FIXME: Remove this version.
     Decl *Import(Decl *FromD);
----------------
a_sidorin wrote:
> these versions
If the other comment is changed I can change this too, but alone this is not worth it. This is anyway a temporary comment, and if the first `Import` there is removed the second can not compile anyway (and the `Import_New` will be the `Import` later).


Repository:
  rC Clang

https://reviews.llvm.org/D53818