[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 14 14:37:17 PST 2018


ahatanak added a comment.

In https://reviews.llvm.org/D54539#1298949, @rjmccall wrote:

> This should not be changing the actual `@`-encoding value.  If we want to use the `@`-encoding in the symbol name, we can change it when naming the symbol, provided that \1 is not legal in the `@`encoding.


This patch defines a new virtual method getObjCEncodingForBlock, which is called only by getBlockDescriptorName. It doesn't change what @encode returns.

Or perhaps I completely misunderstood your comment?


Repository:
  rC Clang

https://reviews.llvm.org/D54539





More information about the cfe-commits mailing list