[PATCH] D54526: [AST] Pack BinaryOperator

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 14 12:51:43 PST 2018


dblaikie added inline comments.


================
Comment at: include/clang/AST/Stmt.h:572
     CastExprBitfields CastExprBits;
+    BinaryOperatorBitfields BinaryOperatorBits;
     InitListExprBitfields InitListExprBits;
----------------
Oh, just a thought - wonder if we could/should have an assert that this anonymous union doesn't grow beyond a certain intended size? (can we have such an assert? I'm not sure how to test the size of an anonymous union - I guess we could static_assert the size of the whole Stmt class, though that'd be a bit brittle)


Repository:
  rC Clang

https://reviews.llvm.org/D54526





More information about the cfe-commits mailing list