[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 14 08:19:51 PST 2018
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D54258#1297687, @richardmembarth wrote:
> > In https://reviews.llvm.org/D54258#1297191, @Anastasia wrote:
> >
> > I agree with the change itself... but it's quite annoying that such things can't be tested. :(
>
> Yes, that's a pity :(
Yeah, it seems like trying to change this in the frontend would also be a fair amount of work.
> Is there anything missing so that this can be merged?
No, I think this truly is untestable without major work. Given how trivial this change is, I'm okay with it.
Repository:
rC Clang
https://reviews.llvm.org/D54258
More information about the cfe-commits
mailing list