[PATCH] D54404: Exclude matchers which can have multiple results

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 14 05:33:48 PST 2018


aaron.ballman added inline comments.


================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:606
+  // be used with particular arguments.
+  static std::vector<StringRef> ExcludedMatchers{
+      "allOf",
----------------
sbenza wrote:
> I don't think we are allowed to have non-trivial static storage duration objects like this.
> You have to use llvm::ManagedStatic. Or just make it a raw array.
IIRC, that's only needed for global statics, not local statics. Local statics are less terrifying than their global brethren. 


Repository:
  rC Clang

https://reviews.llvm.org/D54404





More information about the cfe-commits mailing list