[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

[Miklos Vajna via Phabricator via cfe-commits]

vmiklos added a comment.

As far as I see GCC warns on these 3 things.



================
Comment at: lib/Lex/PPDirectives.cpp:553
         } else {
           const SourceLocation CondBegin = CurPPLexer->getSourceLocation();
           // Restore the value of LexingRawMode so that identifiers are
----------------
Is `CondBegin` still needed after your changes?


================
Comment at: lib/Lex/PPDirectives.cpp:563
           if (Callbacks) {
             const SourceLocation CondEnd = CurPPLexer->getSourceLocation();
+            Callbacks->Elif(
----------------
Is `CondEnd` still needed after your changes?



================
Comment at: lib/Lex/PPExpressions.cpp:852
     DisableMacroExpansion = DisableMacroExpansionAtStartOfDirective;
     return {false, DT.IncludedUndefinedIds};
   }
----------------
The new `ExprRange` member is not initialized here, it seems.



https://reviews.llvm.org/D54450