[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

In https://reviews.llvm.org/D52674#1297879, @rjmccall wrote:

> I'm not worried about the mangler being re-used for multiple declarations, I'm worried about a global flag changing how we mangle all components of a type when we only mean to change it at the top level.


Hmm, but don't we want it to affect all components? For example, consider something like:

  @interface I
  @end
  
  template <class T> class C {};
  
  void f();
  void g() {
    try {
      f();
    } catch (C<I> *) {
    }
  }

I would say that we want the RTTI for `C<I> *` to have the discriminator for `I`. It turns out my current patch doesn't actually do that; I guess there's a sub-mangler being constructed somewhere that's not inheriting the RTTI-ness. Or did you mean something else?


Repository:
  rC Clang

https://reviews.llvm.org/D52674