[PATCH] D54356: Convert CheckICE into a statment visitor

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

Can you explain more about the justification for this? The code today has a covered switch, which is useful for maintainability -- anyone adding a new `Expr` node gets told they need to think about and update this code. Are there any cases where we check for an ICE and aren't in a constant context? I would have expected that the fact we're asking implies that we are in a constant context (at least when the answer is "yes").


Repository:
  rC Clang

https://reviews.llvm.org/D54356