[PATCH] D53488: [clang-tidy] Improving narrowing conversions
Guillaume Chatelet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 13 05:40:04 PST 2018
gchatelet added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:299
+ Rhs->isCXX11ConstantExpr(Context, &Constant)) {
+ if (Constant.isFloat())
+ diagIfNarrowFloatingPointConstant(Context, SourceLoc, Lhs, Rhs, Constant);
----------------
JonasToth wrote:
> Why is the return here `true` even without diagnostic?
Good catch
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
More information about the cfe-commits
mailing list