[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

Tue Nov 13 01:07:41 PST 2018

hans marked 3 inline comments as done.
hans added a comment.

Thanks for the review! I made adjustments in r346748.

================
Comment at: cfe/trunk/docs/UsersManual.rst:3104
+
+This causes the class-level `dllexport` and `dllimport` attributes not to be
+applied to inline member functions, as they otherwise would. For example, in
----------------
thakis wrote:
> "to not be applied" sounds more correct to me, but I'm not a native speaker either. And I think "to not apply to inline member functions" works to and is shorter and not passive, and it makes the part after the comma sound better (with the passive I think it might have to be "as they otherwise would be"?)
Yeah, "to not apply to inline member functions" is better.

Repository:
  rL LLVM

https://reviews.llvm.org/D54319