[PATCH] D54324: [AST] Store the value of CharacterLiteral in the bit-fields of Stmt if possible

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 12 12:50:06 PST 2018


shafik added inline comments.


================
Comment at: include/clang/AST/Expr.h:1407
 public:
-  enum CharacterKind {
-    Ascii,
-    Wide,
-    UTF8,
-    UTF16,
-    UTF32
-  };
+  enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 };
 
----------------
Minor comment, does it make sense to covert this to a scoped enum since it looks like it is being strictly used as a set of values.


Repository:
  rC Clang

https://reviews.llvm.org/D54324





More information about the cfe-commits mailing list