[PATCH] D54407: Record the matcher type when storing a binding

Mon Nov 12 08:03:32 PST 2018

steveire added a comment.

In https://reviews.llvm.org/D54407#1295555, @sbenza wrote:

> In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote:
>
> > Adding @sbenza in case he has opinions on this approach. I think it's reasonable, but I also know that changes to the the AST matcher internals sometimes have unintended side effects with the various instantiations.
>
>
> The problem used to come with the number of template instantiations, but afaik this was with an MSVC configuration that is no longer supported.
>  In any case, I don't see this change making new template instantiations.
>
> I also don't see any actual use of this newly stored data so I don't see the goal. Is this for diagnostics on failures or something like that?

This commit is part of a series. You can see the use of this in the next commit: https://reviews.llvm.org/D54408

Repository:
  rC Clang

https://reviews.llvm.org/D54407