[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 12 08:01:19 PST 2018


hokein added inline comments.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:55
   FuzzyFindRequest Request;
+  Request.AnyScope = true;
   // Remove leading "::" qualifier as FuzzyFind doesn't need leading "::"
----------------
ioeric wrote:
> I don't think you would want AnyScope here. For example, if `QualifiedName` is std::string, you can also get `llvm::StringRef` in the results.
Yeah, the input is required qualified name, I misthought that we can use unqualified name.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54427





More information about the cfe-commits mailing list