[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington accepted this revision.
erik.pilkington added a comment.

LGTM too, with one small fix in test. Thanks for working on this!



================
Comment at: test/CodeGenCXX/attr-no-destroy-d54344.cpp:4
+// RUN: %clang_cc1 -std=c++2a -emit-llvm -O0 -triple x86_64-unknown-linux-gnu -DNOATTR -fno-c++-static-destructors %s -o - | FileCheck %s --check-prefix=CHECK-FLAG 
+// REQUIRES: asserts
+
----------------
Why do you require asserts here? If this test still passes regardless of whether clang was compiled with assertions enabled, we should always run it.


Repository:
  rC Clang

https://reviews.llvm.org/D54344