[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

Miklos Vajna via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 12:31:24 PST 2018


vmiklos marked an inline comment as done.
vmiklos added inline comments.


================
Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:19-22
+struct Entry {
+  SourceLocation Loc;
+  std::string MacroName;
+};
----------------
Szelethus wrote:
> This is a way too general name in my opinion. Either include comments that describe it, or rename it (preferably both).
Renamed to `PreprocessorCondition`, hope it helps. :-)


https://reviews.llvm.org/D54349





More information about the cfe-commits mailing list