[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 10:39:38 PST 2018


Szelethus added inline comments.


================
Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:19-22
+struct Entry {
+  SourceLocation Loc;
+  std::string MacroName;
+};
----------------
This is a way too general name in my opinion. Either include comments that describe it, or rename it (preferably both).


https://reviews.llvm.org/D54349





More information about the cfe-commits mailing list