[PATCH] D53771: [clang-tidy] Avoid C arrays check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 08:10:39 PST 2018


JonasToth added a comment.

In https://reviews.llvm.org/D53771#1294244, @lebedev.ri wrote:

> *Maybe* we should be actually diagnosing the each actual declaration, not just the `typeloc`.
>  Else if you use one `typedef`, and `// NOLINT` it, you will silence it for all the decls that use it.


As my BB is getting closer to being useful, we can gather some statistics first and decide afterwards :)

> In https://reviews.llvm.org/D53771#1294241, @JonasToth wrote:
> 
>> LGTM.
>>  Please give other reviewers a chance to take a look at it too.
> 
> 
> Thank you for the review!
>  I will keep this open for a few more days.

np, i think until monday is enough.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53771





More information about the cfe-commits mailing list