[PATCH] D54379: Add Hurd support
Samuel Thibault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Nov 10 08:00:38 PST 2018
sthibaul marked 3 inline comments as done.
sthibaul added a comment.
I commented one of them, and will fix the rest.
================
Comment at: lib/Driver/ToolChains/Hurd.cpp:36
+ // clever.
+ switch (TargetTriple.getArch()) {
+ default:
----------------
kristina wrote:
> Does this need a switch? Wouldn't an `if` be sufficient?
An if would work, yes, it's just to make it easily extensible for future cases, just like the getMultiarchTriple function in Linux.cpp
Repository:
rC Clang
https://reviews.llvm.org/D54379
More information about the cfe-commits
mailing list