[PATCH] D53771: [clang-tidy] Avoid C arrays check

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added inline comments.


================
Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:26
+  const clang::Type *TypeNode = Node.getTypePtr();
+  return (TypeNode != nullptr &&
+          InnerMatcher.matches(*TypeNode, Finder, Builder));
----------------
Nit: these parens are superflous


================
Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:64
+  diag(ArrayType->getBeginLoc(),
+       isa<VariableArrayType>(ArrayType->getTypePtr()) ? UseVector : UseArray);
+}
----------------
Why `isa<>` and not `isVariableArrayType()` (does it exist?)
`isa<>` would not resolve typedefs, but I think they should be considered.


https://reviews.llvm.org/D53771