[PATCH] D54310: Make clang-based tools find libc++ on MacOS

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This is hacky, but solves an important problem. If you know of a good reviewer for this, you may want a second opinion!



================
Comment at: include/clang/Lex/HeaderSearchOptions.h:111
 
+  /// Compiler install dir as detected by the Driver.
+  /// Only used to add include dirs for libc++ on Darwin. Please avoid relying
----------------
Could you add "typically contains bin/clang, lib/libclang_rt, and include/<builtins>"?


================
Comment at: lib/Frontend/CompilerInvocation.cpp:1776
   Opts.ResourceDir = Args.getLastArgValue(OPT_resource_dir);
+  Opts.InstallDir = Opts.ResourceDir;
 
----------------
(is this needed? I guess you fall back to this if you don't create the CI from the command line?)


Repository:
  rC Clang

https://reviews.llvm.org/D54310