[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 9 07:12:10 PST 2018
hokein added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:555
+ auto Loc = findNameLoc(&ND);
+ if (!shouldIndexFile(SM, SM.getFileID(Loc), Opts, &FilesToIndexCache))
+ return nullptr;
----------------
ioeric wrote:
> Should we use `getTokenLocation` like what we do below?
`getTokenLocation` doesn't return a `SourceLocation`, it returns a `SymbolLocation`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54300
More information about the cfe-commits
mailing list