[PATCH] D54298: [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

[Hans Wennborg via Phabricator via cfe-commits]

hans added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5507
     CmdArgs.push_back("-fno-dllexport-inlines");
+    if (Args.hasArg(options::OPT__SLASH_fallback)) {
+      const Arg *dllexportInlines =
----------------
I think the check should be with the code that handles /fallback, in visualstudio::Compiler::GetCommand, instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D54298