[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜
Stephane Moore via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 8 16:07:33 PST 2018
stephanemoore added inline comments.
================
Comment at: docs/clang-tidy/checks/google-objc-function-naming.rst:20
+ static bool is_positive(int i) { return i > 0; }
+ bool IsNegative(int i) { return i < 0; }
+
----------------
benhamilton wrote:
> This is not actually handled by the check, right? (You even have a test which confirms this.)
>
> As far as I can tell, this check essentially looks for at least one capital letter and no `_` in function names, right?
It does flag this declaration because it's missing an appropriate prefix.
It looks like I neglected to add a test case for that. I have done so now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
More information about the cfe-commits
mailing list