[PATCH] D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:111
+  // Add in the <limits> header, since we know this file uses it.
+  if (auto IncludeFixit = Inserter->CreateIncludeInsertion(
+          SM.getFileID(V->getLocation()), "limits",
----------------
Please don't use auto because type could not be deduced from statement.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:188
+
+  This check is part of the migration checks for moving Zircon user code to use
+  the C++ standard library. It suggests converting uses of declarations in the
----------------
I think first statement is not necessary. Second should start from //Suggests//. Will be good idea to synchronize it with documentation.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:190
+  the C++ standard library. It suggests converting uses of declarations in the
+  ``<fbl/limits.h>`` header to their std counterparts in ``<limits>``.
+
----------------
Please highlight std with ``.


https://reviews.llvm.org/D54169