[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

I think this check is ok in the current form, but does it really need to be in upstream clang-tidy? You said its for migration only, so it is not valuable for you for a long time either?



================
Comment at: clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h:20
+
+/// Replace instances of fbl::move with std::move, and adds the <utility> header
+/// if a replacement occurs.
----------------
Please highlight code with quotes (single or backticks)


================
Comment at: clang-tools-extra/test/clang-tidy/zircon-fbl-move.cpp:5
+
+void move(int i) {}
+
----------------
please add test for aliases, function pointers and similar indirections.


https://reviews.llvm.org/D54168