[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Xing via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 20:51:20 PST 2018


Higuoxing reclaimed this revision.
Higuoxing added a comment.

In https://reviews.llvm.org/D47687#1288272, @vsapsai wrote:

> Sorry, you've decided to abandon the patch, it took a lot of good work. Xing, are you sure you don't want to see this change finished?


No, I am working on this :)

> I agree that delays in code review can be frustrating and I think it is something we can improve.

Never mind :)

Thank you, I am still working on this :) I am afraid this open revision will take up your unnecessary reviewing time or waste your reviewing time, so I close this revision temporarily ... Now, reopen this revision :) Just give me some time :)


https://reviews.llvm.org/D47687





More information about the cfe-commits mailing list