[PATCH] D54106: [clangd] Limit the index-returned results in dexp.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 08:48:15 PST 2018


hokein added inline comments.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:128
   };
   cl::opt<unsigned> Limit{
       "limit",
----------------
ioeric wrote:
> I think we should make it configurable like what we do here.
Made it configurable for `Lookup`. `Limit` option is used to restrict the number for final results, it is reasonable for `FuzzyFind`, and `Lookup`

But for `Refs`, it means the number of different symbols, not the number of final results, I still hard-code it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54106





More information about the cfe-commits mailing list