[PATCH] D54077: [clangd] Implemented DraftFileSystem

Mon Nov 5 07:05:24 PST 2018

klimek added a comment.

In https://reviews.llvm.org/D54077#1287282, @LutsenkoDanil wrote:

> @klimek If behavior will be configurable, is it ok for you?

I have the same concerns as Sam for making this an option.

> @sammccall Current behavior may confuse new users, since, other IDEs mostly (all?) shows diagnostics for edited files instead of saved one. And it's unexpected that headers have 2 states - visible and saved (which cannot be viewed in IDE at all). Looks like performance will be same like usage of 'auto save after delay' feature in editor, if we make debounce delay configurable, what do you think?

don't most IDEs show whether a file is saved or just modified?

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54077