[PATCH] D54104: [Tooling] Correct the total number of files being processed when `filter` is provided.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 06:55:49 PST 2018


ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Tooling/AllTUsExecution.cpp:103
+    if (!RegexFilter.match(File))
+      continue;
+    Files.push_back(File);
----------------
nit: `if (match) then push_back` would be a line shorter.


================
Comment at: lib/Tooling/AllTUsExecution.cpp:125
     }
     llvm::Regex RegexFilter(Filter);
     for (std::string File : Files) {
----------------
This is unused now


Repository:
  rC Clang

https://reviews.llvm.org/D54104





More information about the cfe-commits mailing list